Make the workflow work for Perl scripts without a Perl extension.#3063
Open
drgrice1 wants to merge 1 commit into
Open
Make the workflow work for Perl scripts without a Perl extension.#3063drgrice1 wants to merge 1 commit into
drgrice1 wants to merge 1 commit into
Conversation
This works by checking the first line of the file for a `perl` shebang. That is it checks to see if the first line of a file starts with `#!` and contains `perl` after that. Note that only files in `bin` and `bin/dev_scripts` that do not have the extension `.pl` or `.pm` are checked for the shebang (and not files in a subdirectory of one of those). That is to prevent the workflow and script from becoming much more resource intensive than they already are, and also to skip `conf` files such as `conf/localOverrides.conf.dist` that is not currently "tidy". Both the GitHub workflow and the `bin/dev_scripts/run-perltidy.pl` script are updated for this. All of these files were perltidied in a recent pull request, so this ensures that they stay that way. Also remove the executable bit from `bin/addadmin`. That is a `wwsh` script, and not a script that can be directly executed from the shell. So it should not have the executable bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works by checking the first line of the file for a
perlshebang. That is it checks to see if the first line of a file starts with#!and containsperlafter that. Note that only files inbinandbin/dev_scriptsthat do not have the extension.plor.pmare checked for the shebang (and not files in a subdirectory of one of those). That is to prevent the workflow and script from becoming much more resource intensive than they already are, and also to skipconffiles such asconf/localOverrides.conf.distthat is not currently "tidy".Both the GitHub workflow and the
bin/dev_scripts/run-perltidy.plscript are updated for this.All of these files were perltidied in a recent pull request, so this ensures that they stay that way.
Also remove the executable bit from
bin/addadmin. That is awwshscript, and not a script that can be directly executed from the shell. So it should not have the executable bit.Note that this will not be added to the PG repository since it does not have any of these Perl scripts without extensions.